BFR: Bug

[Urran Voh]

No .gif image I put into a Profile works..Could someone tell me how to correct this?

[sh0e]

did you try dev server?

[Urran Voh]

Putting it on Dev in Profiles didn't work either..but the Clan Crier works...

Warning: getimagesize(http://www.jakooldesigns.com/sofaking_k ... ng_robot_s ig.gif): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found in /home/staron/public_html/faf/SampleParser.php on line 189

Appears at the top of the screen below whatever it is that shows you your turns and such (while viewing the profile). And nothing appears in the Dev profile.

[sh0e]

http://www.jakooldesigns.com/sofaking_kool/jksigs/jk_spaulding_robot_s ig.gif

that image doesnt exist
i designed dev to ignore non existant files

note that the forum parser has problems with the link too
it does not conform to the url standard (the space must be url encoded to %20)
note: i should probably add in url encoding

[Urran Voh]

So what's up with BFR?

Also

http://www.jakooldesigns.com/xchicken/urrahvonsig.gif

didn't work either.

EDIT: Err..Didn't work in my game..

[sh0e]

im starting to realize how dangerous this img filtering is
bandwidth and script overloading..
it might be better off parsing the url text for dangerous code and just letting the browser handle the rest
and also using hardset size limitations or letting the user set size limits

[Urran Voh]

Come again in layman's terms please? :*laughs*:

[sh0e]

ok
right now the script for handling [img] downloads the image and then parses its size so that it can limit the size
this could lead to some abuse and load problems

i am thinking it might be better off just parsing the image url to make sure its not "dirty"
and then letting the browser do its thing

and to settle the size problem.. use a default size
or let the user set a size thats not too big

[Urran Voh]

I see now...Good idea

[The Beatles]

Can this be closed?

[The Beatles]

Also see:
http://frostnflame.org/forum/index.php?showtopic=1660&st=0

[The Beatles]

And:
http://frostnflame.org/forum/index.php?showtopic=1524

[The Beatles]

Ah! We try to wordwrap long images! That is silly.

That now fixed. Developers: changed

code: Select all

$users[profile] = preg_replace('([\S]{75,})', '', $users[profile]);

to

code: Select all

$users[profile] = preg_replace('([\w]{75,})', '', $users[profile]);

i.e. instead of replacing 75 or more non-whitespace characters, we now replace 75 or more "word" characters. Browsers seem to be O.K. with this behaviour.