Code Security Audit

Post by **The Beatles** » Sun Jan 29, 2006 1:13 am

I've started looking over the FAF code for potential security holes proactively. I've found one potentially dangerous issue already, results will be posted once the code audit is over.

Post by **The Beatles** » Sun Jan 29, 2006 11:46 pm

At least one definite SQL injection bug has been found (and fixed).

[edit] Removed, so script kiddies don't run wild with other Promi variants in the wild. ~Beatles

Turock · Post by **Turock** » Mon Jan 30, 2006 4:01 am

I'm assuming that:

$contentious_variable = trim(addslashes($contentious_variable));

before the query would be the fix?

[edit] Removed, so script kiddies don't run wild with other Promi variants in the wild. ~Beatles

Post by **The Beatles** » Mon Jan 30, 2006 5:08 am

I used $contentious_variable = mysql_real_escape_string($contentious_variable);

Our new built-in sqlQuotes() function was modified to use that method as well.

[edit] Removed, so script kiddies don't run wild with other Promi variants in the wild. ~Beatles

Turock · Post by **Turock** » Mon Jan 30, 2006 12:22 pm

I guess its all basically the same. I will use your method so the scripts remain similar.

Turock · Post by **Turock** » Wed Feb 01, 2006 3:13 am

I should have posted that in a PM

Sorry.

Post by **The Beatles** » Wed Feb 01, 2006 6:20 am

I was the indiscreet one to start with. I had been so surprised by the vulnerabilities.

Frost And Flame Forums

Code Security Audit

Members connected in real time